-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Publisher]Agency Settings: edit profileDropdownMetadata and create GlobalStyles.tsx #1271
[Publisher]Agency Settings: edit profileDropdownMetadata and create GlobalStyles.tsx #1271
Conversation
…Your Account,' 'Agency Settings,' and 'Team Management' with the option 'Settings'. Added GlobalStyles.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, Cory! Congrats on your first PR!
There is actually one extra linting rule I forgot to mention that we enforce, which is the license header in each file.
For the publisher/src/components/Global/GlobalStyles.tsx
file, can you add the license header? You can copy and paste it from /justice-counts/license-header.js
or if you want to set up a snippet (that's what I do in my VScode - so you can just type lic
and it will fill it in), you can copy the snippet code at the end of this comment in your IDE's snippets directory.
Also, it might not let you commit a file that's not doing anything - if so, I would create and export the two styled components (GlobalTitle
and GlobalDescription
), but for now you can assign them to an empty template literal ``. That should satisfy the failing CI test.
Snippet code:
{
// Place your global snippets here. Each snippet is defined under a snippet name and has a scope, prefix, body and
// description. Add comma separated ids of the languages where the snippet is applicable in the scope field. If scope
// is left empty or omitted, the snippet gets applied to all languages. The prefix is what is
// used to trigger the snippet and the body will be expanded and inserted. Possible variables are:
// $1, $2 for tab stops, $0 for the final cursor position, and ${1:label}, ${2:another} for placeholders.
// Placeholders with the same ids are connected.
// Example:
// "Print to console": {
// "scope": "javascript,typescript",
// "prefix": "log",
// "body": [
// "console.log('$1');",
// "$2"
// ],
// "description": "Log output to console"
// }
"Code License": {
"prefix": ["lic", "license"],
"body": [
"$LINE_COMMENT Recidiviz - a data platform for criminal justice reform",
"$LINE_COMMENT Copyright (C) $CURRENT_YEAR Recidiviz, Inc.",
"$LINE_COMMENT",
"$LINE_COMMENT This program is free software: you can redistribute it and/or modify",
"$LINE_COMMENT it under the terms of the GNU General Public License as published by",
"$LINE_COMMENT the Free Software Foundation, either version 3 of the License, or",
"$LINE_COMMENT (at your option) any later version.",
"$LINE_COMMENT",
"$LINE_COMMENT This program is distributed in the hope that it will be useful,",
"$LINE_COMMENT but WITHOUT ANY WARRANTY; without even the implied warranty of",
"$LINE_COMMENT MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the",
"$LINE_COMMENT GNU General Public License for more details.",
"$LINE_COMMENT",
"$LINE_COMMENT You should have received a copy of the GNU General Public License",
"$LINE_COMMENT along with this program. If not, see <https://www.gnu.org/licenses/>.",
"$LINE_COMMENT =============================================================================",
],
"description": "The license used at the top of all code files"
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry one more thing, @corypride - can you change the base of this PR to the feature branch? We don't want to merge this into Click Edit up at the top by the PR title and change the base to the feature branch: |
Super smooth branching work, Cory! This one is good to merge into the feature branch - thank you, sir! |
Thank you for your direction.
…On Fri, Mar 29, 2024 at 10:51 AM Mahmoud O. ***@***.***> wrote:
Super smooth branching work, Cory! This one is good to merge into the
feature branch - thank you, sir!
—
Reply to this email directly, view it on GitHub
<#1271 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A43WLSHXREDWPTFMAFPJRLLY2WEZZAVCNFSM6AAAAABFNI34EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGQYTCNJTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
e6cd6cb
into
cory/agency-settings-design-udpates-feature
* [Publisher]Agency Settings: edit profileDropdownMetadata and create GlobalStyles.tsx (#1271) * [Publisher]Agency Settings: edit profileDropdownMetadata to replace 'Your Account,' 'Agency Settings,' and 'Team Management' with the option 'Settings'. Added GlobalStyles.tsx * [Publisher]GlobalStyles.tsx: add license header and 2 component skeletons * [Publisher]GlobalStyles.tsx: removed extra whitespace characters * [Publisher]GlobalStyles.tsx: ran yarn lint --fix * [Publisher]Settings.tsx and SettingsMenu: refactor and removal * Revert "[Publisher]Settings.tsx and SettingsMenu: refactor and removal" This reverts commit 54373c1. * [Publisher]Agency Settings: refactor of Settings.tsx and removal of SettingsMenu.tsx (#1272) * [Publisher]Agency Settings: edit profileDropdownMetadata to replace 'Your Account,' 'Agency Settings,' and 'Team Management' with the option 'Settings'. Added GlobalStyles.tsx * [Publisher]GlobalStyles.tsx: add license header and 2 component skeletons * [Publisher]GlobalStyles.tsx: removed extra whitespace characters * [Publisher]GlobalStyles.tsx: ran yarn lint --fix * [Publisher]Settings.tsx and SettingsMenu: refactor and removal * [Publisher] Agency Settings: Settings page + Account Tab (2/5) #1256 (#1308) * made major changes to the settings page components and all that is connected * [Publisher][Design Update] Agency Settings: Settings page + Account Tab (2/5) * ran yarn lint --fix * manually removed extra space in code on AgencySettings.styles.tsx * removed unused code from AgencySettingsEmailNotifications and AgencySetting.styles * Removed all files that are in the .gitignore * removed TODO notes from AccountSettings.tsx and added suggested styling to GlobalStyles.tsx * removed unused code, replaced custom colors with colors from the palette, fixed some margin and spacing issues in the Settings.styles, AgencySettings.styles, and AccountSettings.styles files * removed custom color and used color from palette and adjusted spacing for email reminder input on AgencySettingsEmailNotifications * created custom components in AgencySettings.Styles to replace divs and spans in the AgencySettingsBasicInfo file * removed div and added styling to custom component in AgencySettings.styles * created a AgencySettingActionRequiredIndicator component and applied logic to show display component next to the section labels of AgencySettingsDescription and AgencySettingsUrl * removed duplicate input component and used an existing one from the common repo and adjusted spacing on severalelements in the AgencySettings sections. * Added flags to Input.tsx and new styles to Input.styled.tsx * Removed duplicate button componenet * used the checkboxOptions component to replace an input checkbox in AgencySettingEmailNotifications * removed unnecessary styling inheritance and made a meaningful name for CheckboxSpacingWrapper in the AgencySettings.styles, added capitialization to the values in the Sectors sectionin the AgencySettingsBasicInfo file * simplified logic on AgencySettingsActionRequiredIndicator in the AgencySettingDescription and AgencySettingsURL pages * changed a variable name * added settigsViewOptions object in prep for using common tabbed bar component * added TabbedBar component to Settings page * removed unused logic on Input.tsx * removed unused logic on Input.tsx * added close-icon-lg.svg to the assets folder * refactored const SettigsViewOptions to use the tabOptions enum in the Settings pg * removed log statement and removed const declaration from tabOptions in Settings page * moved tabOptions enum outside of the Settings function * modified label on settingViewOptions to remove underscore from Team_Members * cleaned up logic statement in AgencySettingsSupervisions * added logic to DescriptionSection in the AgencySettingsEmailNotifications * modified subpopulations modal by left-aligning options * removed const systemsToDisplayInReadMode from AgencySettingSupervisons because we no longer need the filtering that the const provided * renamed the SettingsTitle component -- SettingsTitleContainer and split the font styling between two new components, SettingsTitle and SettingsSubTitle * updated the 'Learn More' link on the Settings page to point to the set-up-metrics page * replaced styling to the NewInput component in Input.styled.tsx * removed unused code in Input component * updated tabOptions enum on Settings page * changed variable name on Settings page * updated initial value of the const currentSettingsView on the Settings page and updated GuideKey to point to AgencySetting * changed logic for the AgencySettingActionRequiredIndicator to depend on purposeAndFunctionsSetting variable * [Publisher][Design Update] Agency Settings: Account Tab Modals (excluding Jurisdictions) (3/5) #1257 (#1327) * made major changes to the settings page components and all that is connected * [Publisher][Design Update] Agency Settings: Settings page + Account Tab (2/5) * ran yarn lint --fix * manually removed extra space in code on AgencySettings.styles.tsx * removed unused code from AgencySettingsEmailNotifications and AgencySetting.styles * Removed all files that are in the .gitignore * removed TODO notes from AccountSettings.tsx and added suggested styling to GlobalStyles.tsx * removed unused code, replaced custom colors with colors from the palette, fixed some margin and spacing issues in the Settings.styles, AgencySettings.styles, and AccountSettings.styles files * removed custom color and used color from palette and adjusted spacing for email reminder input on AgencySettingsEmailNotifications * created custom components in AgencySettings.Styles to replace divs and spans in the AgencySettingsBasicInfo file * removed div and added styling to custom component in AgencySettings.styles * created a AgencySettingActionRequiredIndicator component and applied logic to show display component next to the section labels of AgencySettingsDescription and AgencySettingsUrl * removed duplicate input component and used an existing one from the common repo and adjusted spacing on severalelements in the AgencySettings sections. * Added flags to Input.tsx and new styles to Input.styled.tsx * Removed duplicate button componenet * used the checkboxOptions component to replace an input checkbox in AgencySettingEmailNotifications * removed unnecessary styling inheritance and made a meaningful name for CheckboxSpacingWrapper in the AgencySettings.styles, added capitialization to the values in the Sectors sectionin the AgencySettingsBasicInfo file * simplified logic on AgencySettingsActionRequiredIndicator in the AgencySettingDescription and AgencySettingsURL pages * changed a variable name * added settigsViewOptions object in prep for using common tabbed bar component * added TabbedBar component to Settings page * removed unused logic on Input.tsx * removed unused logic on Input.tsx * added close-icon-lg.svg to the assets folder * refactored const SettigsViewOptions to use the tabOptions enum in the Settings pg * removed log statement and removed const declaration from tabOptions in Settings page * moved tabOptions enum outside of the Settings function * modified label on settingViewOptions to remove underscore from Team_Members * cleaned up logic statement in AgencySettingsSupervisions * added logic to DescriptionSection in the AgencySettingsEmailNotifications * modified subpopulations modal by left-aligning options * removed const systemsToDisplayInReadMode from AgencySettingSupervisons because we no longer need the filtering that the const provided * renamed the SettingsTitle component -- SettingsTitleContainer and split the font styling between two new components, SettingsTitle and SettingsSubTitle * updated the 'Learn More' link on the Settings page to point to the set-up-metrics page * replaced styling to the NewInput component in Input.styled.tsx * removed unused code in Input component * updated tabOptions enum on Settings page * changed variable name on Settings page * updated initial value of the const currentSettingsView on the Settings page and updated GuideKey to point to AgencySetting * changed logic for the AgencySettingActionRequiredIndicator to depend on purposeAndFunctionsSetting variable * added onClickClose function option to the Modal component, added the Modal component to AccountSettings * added email edit modal to the AccountSetting page * updated Modal and Input to allow custom styling options * started adding custom styling to Modal and Input that will apply to the Settings page modals * started adding custom styling to Modal and Input that will apply to the Settings page modals * added custom styling to AccountSettings Modal and the Modal input * updated styling for the modal on AgencySettingsDescription * updated styling on AgencySettingsURL edit modal * added email validation to AccountSettings page * added email url validation and styling to the AccountSettings page * updated the validateAgencyURL logic * removed unused logic in helperUtils * ran linting * added url validation and styling to the AgencySettings page * ran linting * caught bug in validateURL logic that did not meet figma specs for valid or invalid URL * refactored regex on helpUtils validateAgencyURL function * refactored validatAgencyURL function's regex * removed hover styling on button if the logic determines that there should be agencySettingsConfigs * made adjustments to AccountSettings AccountSettingsDescription and URL according to suggestions in PR #1257 * removed unused logic from Modal.tsx. Adjusted AccountSettings and AgencyDescription modals to not persist invalid email or URL on the UI * adjusted AccountSettings, AgencySettingsDescription, and AgencySettingURL modal * removed uneccessary logic from validateEmail function in helperUtils and refactored modal logic in AccountSettings * updated AgencySettingSupervisions and UnsavedChanges modals according to figma docs * ran linting * refactored title and searchbar area of AgencySettingsJurisdictions page * finished refactoring of searchbar for AgencySettingsJurisdictions page * finished refactoring of searchbar for AgencySettingsJurisdictions page * removed opacity setting on Button component * adjusted the logic in the onClickClose function on the AccountSettings page * renamed editModeAndTypeUpdate function to resetEditModeTypeStates and moved some of its functionality to a new function called validateUpdateEmailErrorStates on the AccountSettings page * updated spacing to all agency and account settings modals * updated validation of URL and Email to check validation on change * ran linting * cleaned up logic on AgencySettings pages removed unused code * fixed bug in AgencySettingURL error checking logic and removed the cancel button from AgencySettingsJurisdictions modal
Description of the change
ModifyAgencySettingsMenu.mp4
Type of change
Related issues
Contributes to #1256
Checklists
Development
This box MUST be checked by the submitter prior to merging:
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: