Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Skip Nightfall if Dependabot PR #630

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[Security] Skip Nightfall if Dependabot PR #630

merged 1 commit into from
Oct 24, 2023

Conversation

phenggeler
Copy link
Contributor

Description of the change

Skip Nightfall if Dependabot PR. Nightfall does not work for Dependabot.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes [#XXXX]

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@phenggeler phenggeler requested a review from mxosman October 24, 2023 16:53
@phenggeler phenggeler mentioned this pull request Oct 24, 2023
Merged
@phenggeler phenggeler enabled auto-merge (squash) October 24, 2023 16:54
mxosman
mxosman approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mxosman mxosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - nice! Thank you so much, Peter! LGTM

@phenggeler phenggeler merged commit bdc6667 into main Oct 24, 2023
13 of 14 checks passed
@phenggeler phenggeler deleted the phenggeler-patch-1 branch October 24, 2023 16:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6630044779

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on phenggeler-patch-1 at 78.516%
Totals Coverage Status
Change from base Build 5741901338: 78.5%
Covered Lines: 2135
Relevant Lines: 2557
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxosman mxosman mxosman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phenggeler @coveralls @mxosman