Cannot handle ...arg

[frioux]

When I run goblin -file /home/frew/code/leatherman/internal/tool/status/status.go (code is at https://github.com/frioux/leatherman/blob/54a4c6bc7b0d8e60cdab34be68d7d7708da97690/internal/tool/status/status.go) I get this error:

{
  "error": {
    "info": "*ast.Ellipsis",
    "position": {
      "column": 33,
      "filename": "/home/frew/code/leatherman/internal/tool/status/status.go",
      "line": 76,
      "offset": 2133
    },
    "type": "unrecognized_type"
  }
}

[bagnalla]

I have a fix for this implemented here (see goblin.go). Let me know if you encounter any problem with it.

[frioux]

Doesn't seem to work for me:

$ git remote -v
origin  https://github.com/bagnalla/goblin (fetch)
origin  [email protected]:bagnalla/goblin (push)
$ go build ./cmd/goblin 
$ ./goblin -file /home/frew/code/leatherman/internal/tool/status/status.go
{"error":{"info":"*ast.Ellipsis","position":{"column":33,"filename":"/home/frew/code/leatherman/internal/tool/status/status.go","line":76,"offset":2133},"type":"unrecognized_type"}}

[frioux]

(I tried with both the master branch and the bugfix/variadic-args branch)

[bagnalla]

It's probably still using the goblin package at "github.com/ReconfigureIO/goblin" because the import path in cmd/goblin/main.go still points to it (I didn't change it because I intend to submit the fix as a PR to the main repo).

Try just copying the modified goblin.go from bugfix/variadic-args into $GOPATH/src/github.com/ReconfigureIO/goblin or wherever your Go tool is expecting it to be.

[frioux]

ah yes, that did fix it!

[frioux]

@bagnalla any chance this will get merged in?

[bagnalla]

The maintainers appear to be inactive, so probably not. We have a fork with fixes implemented that you could try using. It's also extended to optionally include type information in the output (see the top of the README).

[frioux]

ah cool, I'll switch it to the fork.

…

On Tue, Jul 21, 2020, 9:40 PM Alexander Bagnall ***@***.***> wrote: The maintainers appear to be inactive, so probably not. We have a fork <https://github.com/GaloisInc/goblin> with fixes implemented that you could try using. It's also extended to optionally include type information in the output (see the top of the README). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAB7Y3LXEOMAKJ5REN4PDLR4ZUSJANCNFSM4OYFYU5A> .

[Evgenus]

@frioux @bagnalla maybe you will be interested https://github.com/asty-org/asty