Add agent and faked_measured_boot_log context #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koncpa
approved these changes
Sep 1, 2022
lkatalin
reviewed
Sep 1, 2022
| @@ -39,3 +39,9 @@ adjust: | |||
| - when: distro == rhel-8 or distro = centos-stream-8 | |||
| enabled: false | |||
| because: RHEL-8 has old tpm2-tools | |||
| - when: agent == rust and faked_measured_boot_log is not defined | |||
| enabled: false | |||
| because: For Rust agent we are not able to fake measuredboot log during runtime | |||
There was a problem hiding this comment.
Just for my understanding, why is this the case?
There was a problem hiding this comment.
Pls see the updated description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functional/measured-boot-swtpm-sanity requires modified agent that reads measured boot log from a different location. For Python agent we can set it on the system but for the Rust agent we need to do it during compilation. By setting the proper context we can control if the test will be enabled or disabled in a test plan.
This is important for testing of distribution packages that were compiled without this hack.