Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optional authentication not rendered properly (#2117) #2134

Merged

Conversation

zalewskigrzegorz
Copy link
Contributor

@zalewskigrzegorz zalewskigrzegorz commented Aug 16, 2022

What/Why/How?

Representing optional authentication on endpoint don't display properly.
image
image

After fix

security:
  - {}
  - basic: []

or

security:
  - basic: []
  -  {}

Should be displayed properly

Reference

#2117

Testing

Unit test added
for manual testing, modify openapi.yaml

      security:
        - api_key: []

to

      security:
        - {}
        - api_key: []

Screenshots (optional)

image
image
image
image
image
image
image
image

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@zalewskigrzegorz zalewskigrzegorz requested a review from a team as a code owner August 16, 2022 23:45
@zalewskigrzegorz zalewskigrzegorz requested review from Oprysk and removed request for a team August 16, 2022 23:45
@AlexVarchuk AlexVarchuk merged commit efd5e09 into Redocly:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants