fix: remove source maps reference from the production build

Refinitiv · Oct 6, 2021 · 655d0bb · 655d0bb
1 parent aad83c7
commit 655d0bb
Show file tree

Hide file tree

Showing 23 changed files with 48 additions and 22 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -27,7 +27,7 @@ jobs:
 
       - run: npm ci --ignore-scripts --audit=false --fund=false
 
-      - run: lerna run build --include-dependencies --since
+      - run: lerna run build:prod --include-dependencies --since
 
       - run: lerna version --conventional-commits --yes
 

diff --git a/package.json b/package.json
@@ -11,6 +11,7 @@
   "scripts": {
     "lerna": "lerna",
     "build": "lerna run build",
+    "build:prod": "lerna run build:prod",
     "start": "node cli start",
     "test": "node cli test",
     "lint": "node cli lint"

diff --git a/packages/configurations/tsconfig.json b/packages/configurations/tsconfig.json
@@ -7,8 +7,8 @@
     "experimentalDecorators": true,
     "esModuleInterop": true,
     "strict": true,
-    "sourceMap": true,
+    "sourceMap": false,
     "declaration": true,
-    "declarationMap": true,
+    "declarationMap": false,
   }
 }
diff --git a/packages/core/.npmignore b/packages/core/.npmignore
@@ -42,4 +42,4 @@ tsconfig.json
 /__demo__/
 
 # map files
-/lib/**/*.d.ts.map
+/lib/**/*.map
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -13,7 +13,8 @@
   "author": "Refinitiv",
   "license": "Apache-2.0",
   "scripts": {
-    "build": "tsc",
+    "build": "tsc --sourceMap --declarationMap",
+    "build:prod": "tsc",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
     "test": "npm run build && karma start ../../karma.config.js --package=core",

diff --git a/packages/demo-block/.npmignore b/packages/demo-block/.npmignore
@@ -42,4 +42,4 @@ tsconfig.json
 /__demo__/
 
 # map files
-/lib/**/*.d.ts.map
+/lib/**/*.map
diff --git a/packages/demo-block/package.json b/packages/demo-block/package.json
@@ -6,8 +6,9 @@
   "module": "./lib/demo-block.js",
   "types": "./lib/demo-block.d.ts",
   "scripts": {
-    "build": "tsc",
-    "build:watch": "tsc --watch --preserveWatchOutput --sourceMap",
+    "build": "tsc --sourceMap --declarationMap",
+    "build:watch": "npm run build -- --watch --preserveWatchOutput",
+    "build:prod": "tsc",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
     "start": "npm run build && concurrently \"npm run build:watch\" \"web-dev-server --config ../../server.config.js --app-index __demo__\"",

diff --git a/packages/elemental-theme/package.json b/packages/elemental-theme/package.json
@@ -18,6 +18,7 @@
     "build:light": "theme-compiler light --variant=light",
     "build:dark": "theme-compiler dark --variant=dark",
     "build": "npm run build:light && npm run build:dark",
+    "build:prod": "npm run build",
     "watch": "watch \"npm run build\" src --wait=10"
   },
   "devDependencies": {

diff --git a/packages/elements/.npmignore b/packages/elements/.npmignore
@@ -44,7 +44,7 @@ tsconfig.json
 /__demo__/
 
 # map files
-/lib/**/*.d.ts.map
+/lib/**/*.map
 
 # config
 *.config.js

diff --git a/packages/elements/package.json b/packages/elements/package.json
@@ -20,7 +20,8 @@
     "./lib/*": "./lib/*/index.js"
   },
   "scripts": {
-    "build": "node cli build",
+    "build": "node cli build --sourceMap --declarationMap",
+    "build:prod": "node cli build",
     "start": "node cli start",
     "test": "node cli test",
     "test:watch": "node cli test --watch",

diff --git a/packages/elements/scripts/cmd/build.js b/packages/elements/scripts/cmd/build.js
@@ -10,16 +10,30 @@ exports.builder = yargs => {
       type: 'boolean',
       default: false,
       description: 'Watch file change'
+    })
+    .option('sourceMap', {
+      type: 'boolean',
+      default: false,
+      description: 'Create source map files for emitted JavaScript files.'
+    })
+    .option('declarationMap', {
+      type: 'boolean',
+      default: false,
+      description: 'Create sourcemaps for d.ts files.'
     });
 };
 exports.handler = (argv) => {
   const watch = !!argv.watch;
+  const sourceMap = !!argv.sourceMap;
+  const declarationMap = !!argv.declarationMap;
 
   info(watch ? 'Watch element changes' : 'Build all elements');
 
   try {
     const command = ['tsc'];
-    watch && command.push('--watch', '--preserveWatchOutput', '--sourceMap');
+    watch && command.push('--watch', '--preserveWatchOutput');
+    sourceMap && command.push('--sourceMap');
+    declarationMap && command.push('--declarationMap');
 
     execSync(command.join(' '), { stdio: 'inherit' });
 

diff --git a/packages/halo-theme/package.json b/packages/halo-theme/package.json
@@ -18,6 +18,7 @@
     "build:dark": "theme-compiler dark --variant=dark",
     "build:light": "theme-compiler light --variant=light",
     "build": "npm run build:dark && npm run build:light",
+    "build:prod": "npm run build",
     "watch": "watch \"npm run build\" src --wait=10"
   },
   "dependencies": {

diff --git a/packages/i18n/.npmignore b/packages/i18n/.npmignore
@@ -42,4 +42,4 @@ tsconfig.json
 /__demo__/
 
 # map files
-/lib/**/*.d.ts.map
+/lib/**/*.map
diff --git a/packages/i18n/package.json b/packages/i18n/package.json
@@ -11,7 +11,8 @@
     "directory": "packages/i18n"
   },
   "scripts": {
-    "build": "tsc",
+    "build": "tsc --sourceMap --declarationMap",
+    "build:prod": "tsc",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
     "test": "npm run build && karma start ../../karma.config.js --package=i18n --include-snapshots=false",

diff --git a/packages/phrasebook/.npmignore b/packages/phrasebook/.npmignore
@@ -42,4 +42,4 @@ tsconfig.json
 /__demo__/
 
 # map files
-/lib/**/*.d.ts.map
+/lib/**/*.map
diff --git a/packages/phrasebook/package.json b/packages/phrasebook/package.json
@@ -13,7 +13,8 @@
     "directory": "packages/phrasebook"
   },
   "scripts": {
-    "build": "tsc",
+    "build": "tsc --sourceMap --declarationMap",
+    "build:prod": "tsc",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
     "test": "npm run build && mocha __test__/**/*.js --require esm"

diff --git a/packages/solar-theme/package.json b/packages/solar-theme/package.json
@@ -18,6 +18,7 @@
     "build:charcoal": "theme-compiler charcoal --variant=charcoal",
     "build:pearl": "theme-compiler pearl --variant=pearl",
     "build": "npm run build:charcoal && npm run build:pearl",
+    "build:prod": "npm run build",
     "watch": "watch \"npm run build\" src --wait=10"
   },
   "dependencies": {

diff --git a/packages/test-helpers/.npmignore b/packages/test-helpers/.npmignore
@@ -41,4 +41,4 @@ tsconfig.json
 /__demo__/
 
 # map files
-/lib/**/*.d.ts.map
+/lib/**/*.map
diff --git a/packages/test-helpers/package.json b/packages/test-helpers/package.json
@@ -13,7 +13,8 @@
   "author": "Refinitiv",
   "license": "Apache-2.0",
   "scripts": {
-    "build": "tsc --sourceMap false",
+    "build": "tsc --sourceMap --declarationMap",
+    "build:prod": "tsc",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
     "test": "npm run build && karma start ../../karma.config.js --package=test-helpers --include-snapshots=false",

diff --git a/packages/translate/.npmignore b/packages/translate/.npmignore
@@ -42,4 +42,4 @@ lib/test/
 /__demo__/
 
 # map files
-/lib/**/*.d.ts.map
+/lib/**/*.map
diff --git a/packages/translate/package.json b/packages/translate/package.json
@@ -13,8 +13,9 @@
     "directory": "packages/translate"
   },
   "scripts": {
-    "build": "tsc --sourceMap false",
-    "build:watch": "tsc --watch --preserveWatchOutput --sourceMap",
+    "build": "tsc --sourceMap --declarationMap",
+    "build:prod": "tsc",
+    "build:watch": "npm run build -- --watch --preserveWatchOutput",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
     "start": "npm run build && concurrently \"npm run build:watch\" \"web-dev-server --config ../../server.config.js --app-index __demo__\"",

diff --git a/packages/utils/.npmignore b/packages/utils/.npmignore
@@ -41,4 +41,4 @@ tsconfig.json
 /__demo__/
 
 # map files
-/lib/**/*.d.ts.map
+/lib/**/*.map
diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -15,7 +15,8 @@
   "scripts": {
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
-    "build": "tsc --sourceMap false"
+    "build": "tsc --sourceMap --declarationMap",
+    "build:prod": "tsc"
   },
   "dependencies": {
     "@types/d3-color": "^2.0.1",