-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding type=module
to package.json
#974
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Pull requests that update a dependency file
enhancement
New feature or request
v7
EF version 7
labels
Sep 26, 2023
Deploying with Cloudflare Pages
|
Size Change: -3.3 kB (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
wsuwt
changed the title
feate: adding
feat: adding Sep 27, 2023
type=module
to package.json
type=module
to package.json
…hub.com/Refinitiv/refinitiv-ui into feat/adding-type-module-to-package-json
Needs #989 to be merged to solve build failure. |
wattachai-lseg
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
Co-authored-by: wattachai <[email protected]>
Co-authored-by: wattachai <[email protected]>
Co-authored-by: wattachai <[email protected]>
wattachai-lseg
previously approved these changes
Oct 11, 2023
…hub.com/Refinitiv/refinitiv-ui into feat/adding-type-module-to-package-json
wattachai-lseg
previously approved these changes
Oct 18, 2023
LGTM |
Sarin-Udompanish
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
enhancement
New feature or request
v7
EF version 7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that ESM specifications are stable and widely supported, it is recommended that we explicitly specify the module system we used among our packages. Adding
type="module"
in nearestpackage.json
is one way to do so. This tells Node.js the module system we want to use in each package.Reference: https://nodejs.org/api/packages.html#determining-module-system
Checklist