-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tree-select): inconsistency Collapse all
behavior with disabled item
#987
Draft
Nantawat-Poothong
wants to merge
6
commits into
v7
Choose a base branch
from
fix/tree-select-cant-collapse-all-with-all-disabled-parent
base: v7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix(tree-select): inconsistency Collapse all
behavior with disabled item
#987
Nantawat-Poothong
wants to merge
6
commits into
v7
from
fix/tree-select-cant-collapse-all-with-all-disabled-parent
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Size Change: -13 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
Nantawat-Poothong
changed the title
fix(tree-select): inconsistency collapse all behavior with disabled item
fix(tree-select): inconsistency Oct 6, 2023
Collapse all
behavior with disabled item
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expand all/Collapse all action they should work in the same way
in this case I tried to make Expand all/Collapse all still working with disabled parent items
TODO
Ready for review
Sandbox
https://codesandbox.io/s/12330-tree-select-collapse-all-forked-5vkp5f?file=/src/index.ts
Fixes # (issue)
https://jira.refinitiv.com/browse/ELF-2311
Checklist