Add .NET 6 and C# 10 Support #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RehanSaeed
added
enhancement
|
@Turnerj I tried adding net6.0 to the tool project and found new warnings/errors but I could not then get the main Schem.NET project to build, so rolled that back but kept the fixes for the warning/errors. So the source generator can't target multiple target frameworks? Can we upgrade from netstandard2.0? |
|
Source generators always have to target .NET Standard 2.0 unfortunately - it is a limitation baked into how they are invoked I believe. Might change when/if VS is no longer using .NET Framework. |
Turnerj
reviewed
Oct 16, 2021
RehanSaeed
force-pushed
the
add-dotnet-6-and-csharp-10
branch
from
5997177 to
e4cea21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.mdto NuGet packages (https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packagereadmefile).net6.0.net461.ArgumentNullException.ThrowIfNull(...).Will update the
.editorconfigin a later PR and go with file scoped namespaces.