Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Incremental Source Generators #591

Merged
merged 1 commit into from
May 22, 2023
Merged

Use Incremental Source Generators #591

merged 1 commit into from
May 22, 2023

Conversation

Turnerj
Copy link
Collaborator

@Turnerj Turnerj commented May 21, 2023 •
edited
Loading

This should do a few little things for us:

  • Uses the typical source generator way for referencing files
  • Simplifies the source generation by removing the async/await path (drops the use of Stream due to the first point)

This may make it a little faster/easier in Visual Studio to use the solution (I've had issues in the past and basically just have been disabling Schema.NET.Pending so it wasn't so slow).

@Turnerj Turnerj added enhancement Issues describing an enhancement or pull requests adding an enhancement. maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. labels May 21, 2023
@Turnerj Turnerj requested a review from RehanSaeed May 21, 2023 14:14
@Turnerj Turnerj mentioned this pull request May 21, 2023
Open
@RehanSaeed RehanSaeed added minor Pull requests requiring a minor version update according to semantic versioning. and removed enhancement Issues describing an enhancement or pull requests adding an enhancement. labels May 22, 2023
@RehanSaeed RehanSaeed merged commit 4b0906f into RehanSaeed:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanSaeed RehanSaeed RehanSaeed approved these changes

Assignees
No one assigned
Labels
maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. minor Pull requests requiring a minor version update according to semantic versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turnerj @RehanSaeed