chore: fix CI and refactor patch deployment script #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yomarion
commented
Apr 12, 2023
fungible_proxy/src/lib.rs
Outdated
| @@ -181,7 +181,7 @@ impl FungibleProxy { | |||
| } else { | |||
| // return full amount for `ft_resolve_transfer` on the token contract | |||
| let change = (amount.0 + args.fee_amount.0).to_string(); | |||
| log!("Failed to transfer to account {}. Returning attached amount of {} of token {} to {}", args.to, change, token_address, payer); | |||
| log!("Transfer failed to {} or {}. Returning attached amount of {} of token {} to {}", args.to, args.fee_address, change, token_address, payer); | |||
There was a problem hiding this comment.
We don't know which transfer failed. We could but the token will probably throw an explicit error anyway.
MantisClone
requested changes
Apr 19, 2023
|
|
||
| ./build.sh | ||
|
|
||
| if [ "$contract_name" = "fungible_proxy" ]; then | ||
| set -x |
There was a problem hiding this comment.
Is this for debugging? Do you want to keep it in there?
There was a problem hiding this comment.
Yes, I plan to keep it here to show the commands that are run, so it's easier to understand what's going on, especially if something went wrong, but not only.
yomarion
force-pushed
the
chore/deploy-script-refactor-patch
branch
from
2208b8e to
e9a56d8
Compare
yomarion
changed the title
MantisClone
reviewed
Sep 18, 2023
MantisClone
reviewed
Sep 18, 2023
MantisClone
approved these changes
Sep 18, 2023
Co-authored-by: MantisClone <[email protected]>
Co-authored-by: MantisClone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bandaid for #20
fix: CI with
rustup default 1.67.0quick-winchore: Github workflow should only run on PR targeting master or push to master, not on every push
chore: Github workflow includes linting checks (+ checks applied)
chore: refactor patch deployment script
chore: fix error log when one transfer goes wrong