Rename "Attribute" rule to "Property" #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriquemoody
force-pushed
the
property
branch
3 times, most recently
from
9259ea2 to
4389e4d
Compare
|
Again, I wasnt't expecting more contributors :D (see #1424 (comment)). I agree with this change and I'm willing to move it forward, we just need to figure out how we deal with the branches to keep 2.3 without this BC break, and introduce it later (2.4 or something else). |
|
I'm not in a rush to get any of my changes merged. I was writing some code just because, as a manager, I sometimes miss coding :D |
Because now we have the concept of attributes in PHP, the rule with the name "Attribute" makes no sense because it doesn't validate attributes but properties. In the future, it might be possible that Validation will have a rule called "Attribute" to validate PHP attributes. Signed-off-by: Henrique Moody <[email protected]>
henriquemoody
force-pushed
the
property
branch
from
4389e4d to
250fd93
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1418 +/- ##
=========================================
Coverage 94.91% 94.91%
Complexity 981 981
=========================================
Files 195 195
Lines 2223 2223
=========================================
Hits 2110 2110
Misses 113 113 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because now we have the concept of attributes in PHP, the rule with the name "Attribute" makes no sense because it doesn't validate attributes but properties.
In the future, it might be possible that Validation will have a rule called "Attribute" to validate PHP attributes.