401 php label #403
401 php label #403
Conversation
|
Could you please create PHPLabel.md on "docs" directory? |
| public function testInvalidPHPLabelShouldThrowPhoneException($input) | ||
| { | ||
| $this->assertFalse($this->phpLabelValidator->__invoke($input)); | ||
| $this->assertFalse($this->phpLabelValidator->assert($input)); |
There was a problem hiding this comment.
Just to point out, all assert methods on PHPUnit are static. This might stop working at some point in the future.
There was a problem hiding this comment.
I think it's not going to happen, see sebastianbergmann/phpunit#1914 (comment)
There was a problem hiding this comment.
Doesn't depend on him, but rather on PHP itself becoming stricter over time and hacks like this being removed; which admittedly won't happen just yet. Regardless of what Sebastian Bergmann says, $this-> to access a static method is wrong and might stop working in the future.
PHPUnit's hardly an example of good php code.
There was a problem hiding this comment.
When/if it happens a single line of shell script can change the entire test suite and, since it's not BC break, because it's on the test suite, it can be changed in any version.
I think you're right (on many points), but until it happens I think we should stick with what is a common and widely accepted standard, don't you think?
There was a problem hiding this comment.
You're right indeed 👍 . Just trying to raise awareness as lots of people haven't realised never having looked at PHPUnit assertions code.
|
Closed by f40eb63 Thanks for contributing! 🐼 |
Exactly the same as #402 but against a dedicated branch. Fixes #401