-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow CSS escapes? #97
Comments
Although the media attribute already appears to support escapes, I'm not comfortable with doing that for srcset and sizes. Also I think this issue is bigger than whether CSS escapes are supported. The error handling is also different from old srcset. If the value doesn't match the grammar, the whole thing is ignored. I think this makes it hard to extend the attributes in the future while providing fallback, for instance if type() is added then legacy UAs would ignore the whole attribute. |
Old srcset had it as an explicit design feature that it should be possible to extend in future. Important catch. Question is, does anyone actually think different? How to best fix it? Take parse algorithm from original srcset? |
I don't think we need to support CSS escapes in sizes and srcset. |
@velmont yeah I think we should write out the parsing algorithm similar to original srcset. |
Let's discuss sizes separately... |
Parse srcset attribute more like original srcset. Fixes #97
Closed by zcorpan@8b9af32 |
@annevk points out that the new syntax appears to support CSS escapes e.g. in the url in srcset. I'm not sure that is intentional or desirable and it doesn't match "old" srcset.
The text was updated successfully, but these errors were encountered: