Implemented 'info' command for NTAG424 #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
I removed that unused param. |
Not needed now when the unused parameter is gone.
|
Awesome, that made it a bit better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented GetVersion and GetSignature commands for NTAG424, and added getting/printing of them in the "info" command.
I did a dubious thing by making the signature verification from DESFire public by making a wrapper function that didn't need to supply card_type. Seems like that parameter is not needed anyway.
The version information command is the same as for desfire, so might have been possible to use that instead, but the signature was not readable by the desfire commands.