mfkey: add explicit -lpthread link directive to Makefile for linux builds #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te older linux versions when libpthread was a separate library
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
Thanks for the PR! Now, two PRs , two different solutions. Which to choose. SKIPTHREAD seems to be the right path considering its purpose. If noone else has any objections, I will close this PR and merge the other. |
|
Merged the other PR regarding this problem,. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nested_util.crequires pthread support. Prior to release 2.34 of glibc (around Aug 2021), libpthread was a separate library that needed to be explicitly supplied to the linker. Add the directive to make all linux builds happy.