Fix pthreads on older gcc #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phreakmonkey
commented
Nov 14, 2023
phreakmonkey
commented
- Used $(SKIPPTHREAD) test result from client/CMakeLists.txt
- Tested on Debian Linux 11 (bullseye), build issue resolved
|
You are welcome to add an entry to the CHANGELOG.md as well |
Closed
|
(Someone with a newer gcc / distro should test this and make sure my conditional is valid / the build still works there too!) |
phreakmonkey
referenced
this pull request
Nov 14, 2023
… The Chameleon Ultra impl and PM3 Impl.\nRunning the test script will show how the CU impl has some issues
|
Thanks for the PR! Now, two PRs , two different solutions. Which to choose. SKIPTHREAD seems to be the right path considering its purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.