Prevent sending corrupt data to em4x70 w/--par option
#2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This autorecovery test key also has three potential matches for the last phase, thus ensuring authentication test is required to determine which of those keys was actually used.
|
You are welcome to add an entry to the CHANGELOG.md as well |
Signed-off-by: Iceman <[email protected]>
|
Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR related to #2376 .
PM3_*value (not boolean). Thanks to @iceman1001 for noting these errors so they could be fixed!lf em 4x70 autorecoverNOTE: MacOS builds fail due to Python install issue. This is fixed with PR #2380.
Even so, linked are GitHub action results from a branch with one extra commit that disables the broken HiTag2 test:
future work
If hardware is found that requires this option, a later PR may re-enable this option.
Alternatively, a later PR may entirely remove the
--paroption fromlf em 4x70.