feat: fix .replace() when searching string, add .replaceAll()
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
Sep 7, 2022
test/MagicString.js
Outdated
| @@ -1305,7 +1305,28 @@ describe('MagicString', () => { | |||
|
|
|||
| s.replace('2', '3'); | |||
|
|
|||
| assert.strictEqual(s.toString(), '1 3 1 2'); | |||
| assert.strictEqual(s.toString(), '1 3 1 3'); | |||
There was a problem hiding this comment.
If we don't want add .replaceAll, I guess we should just replace them all.
There was a problem hiding this comment.
I guess it makes better sense to align with JavaScript's string, so I'd prefer adding .replaceAll and keeping .replace only replaced once.
|
@antfu Can you take a look? |
antfu
reviewed
Sep 14, 2022
src/MagicString.js
Outdated
| } | ||
|
|
||
| replace(searchValue, replacement) { | ||
| return this[typeof searchValue === 'string' ? '_replaceString' : '_replaceRegexp']( |
There was a problem hiding this comment.
Can we use an if condition instead of props accessing? Thanks.
|
All review points addressed. |
fisker
changed the title
.replace() when searching string.replace() when searching string, add .replaceAll()
antfu
changed the title
.replace() when searching string, add .replaceAll().replace() when searching string, add .replaceAll()
|
Awesome, thanks! |
|
Should have added "replaceAll" to the typescript definition file! See the PR I have submitted right now: #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #221