Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37
Some notes:
EmailMessageServiceProvider
extending from Laravel'sEventServiceProvider
messes up event registrationMessageSent
event, and they only extend fromIlluminate\Support\ServiceProvider
EventServiceProvider@listen
get registered again, and the listener of the package gets registered automatically via autodiscovery againEventServiceProvider
just to useEvent::listen
, since you could technically useEvent::listen
from any service provider, so extending fromServiceProvider
should be alright and is probably more correct. It seems extending fromIlluminate\Events\EventServiceProvider
is what broke listener registration on our end