Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing storage option in resend and delete #66

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

cooljet84
Copy link
Contributor

Added the new storage option in Resend & attachment delete

Copy link

what-the-diff bot commented Jun 18, 2024

PR Summary 🚀

Your superheroes (our developers) 👨‍💻 have returned with an exciting new update! Let's uncover what's under the hood! ⚙️

  • Improved Email Attachments Handling 📧
    In ResendMail.php, our team has added some cool lines of code that allow us to fetch the 'attachments_disk' configuration more efficiently, they used $storageDisk for that. Plus, we have now replaced the fromPath() method with fromStorageDisk() method to provide a better way of managing email attachments. 👏

  • Optimized Email Storage 💾
    We've imported the Storage facade in Email.php, which is a super fancy tool that helps us manage file storage better. Also, we've made some neat tweaks in the email deleting event, including revision and optimization of how we check file existence and delete files (making it more reliable! 🔒), and better management of directories. Think of it as housekeeping, but for your emails. 🧹

  • Better Email Archiving Criteria 📆
    Finally, in the prunable() function, we've refined our filters to archive older emails using a more reliable condition, ensuring we keep things neat and trim by only storing emails up to certain days old.⏳

These updates will add up to make the whole system work more smoothly. Enjoy! 🎉

@RickDBCN RickDBCN merged commit 6005afd into RickDBCN:main Jun 19, 2024
11 checks passed
@RickDBCN
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants