Add support for ESLint v9 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frantic1048
force-pushed
the
feature/eslint-v9
branch
13 times, most recently
from
765af4a to
614f250
Compare
frantic1048
force-pushed
the
feature/eslint-v9
branch
3 times, most recently
from
57a7808 to
8676cd8
Compare
deprecates legacy packages: - `@rightcapital/eslint-config-base` - `@rightcapital/eslint-config-javascript` - `@rightcapital/eslint-config-typescript` - `@rightcapital/eslint-config-typescript-react` resolves #128
frantic1048
force-pushed
the
feature/eslint-v9
branch
from
8676cd8 to
e28c101
Compare
liby
approved these changes
Oct 14, 2024
lixiaoyan
approved these changes
Oct 15, 2024
We may add this in later versions. This PR aims to bring ESLint v9 support with least changes to features as possible. |
frantic1048
added a commit
that referenced
this pull request
Oct 18, 2024
We have used import attributes feature, setting proper `engines.node` field helps user select the right Node.js version References: - 18.20.0: https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2024-03-26-version-18200-hydrogen-lts-richardlau - 20.10.0: https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md#2023-11-22-version-20100-iron-lts-targos - 21.1.0: https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V21.md#2023-10-24-version-2110-current-targos relates to #204
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
@rightcapital/eslint-configpackage will target ESLint v9, provide various configurations for different usages, and receive future updates.@rightcapital/eslint-config-*packages will continue to support ESLint v8, but we may deprecate them in favor of the new@rightcapital/eslint-config.Changes
Packages:
@rightcapital/eslint-config(new package), targets ESLint v9, almost have the same rules with@rightcapital/eslint-config-*, with following differences:no-new-symboltono-new-native-nonconstructorfiles(likesoverridesin ESLint v8) in recommended config, this would hugely reduce users config to apply different rules for different files. (It already makes the ESLint config in this repo clearer.)Removed legacy packages (we may deprecate them on npm later):
@rightcapital/eslint-config-base@rightcapital/eslint-config-javascript@rightcapital/eslint-config-typescript@rightcapital/eslint-config-typescript-reactE2E tests:
specs/eslint-configs-legacy: renamed fromspecs/eslint-configs, target ESLint v8, test configs for@rightcapital/eslint-config-*.specs/eslint-configs: target ESLint v9, test the new@rightcapital/eslint-config.Docs:
As 1.i.b. mentioned, the ESLint config in this repo has been migrated to the new
@rightcapital/eslint-configand ESLint v9.This resolves #128.