-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Varint and README code unit tests #79
base: main
Are you sure you want to change the base?
Conversation
@RiotTuxedo 👋 sorry for the ping. I saw others do it and this PR has been sitting for a while. |
Hey ed, I'm focusing mainly on helping to keep the documentation up-to-date. The lor engineers handle updating the repo with the logic to support new deck codes and the tests. They'd have to review your changes and decide if they want to accept it into the code. I'll let one of them know there's an open PR, but there's no guarantees they'd have time to review and merge it. |
👍 sg, no worries. |
Ah makes sense. That's one of the lor devs that didn't have access to merge the changes for the latest set. |
Ah right on, appreciate the context - sorry again for the ping |
ProjectReference Include filename was 'LorDeckCodes.csproj'. Change to 'LoRDeckCodes.csproj' (capitalize first R)
* netcoreapp2.0 used in both projects. This version is EOL. Update the LTS version 3.1 (2022-12-03) * Resolve Package warning message: "warning NETSDK1138: The target framework 'netcoreapp2.0' is out of support and will not receive security updates in the future." * Try and make csproj spacing consistent
* Following https://google.github.io/styleguide/csharp-style.html#organization * Remove unused `Newtonsoft.Json` package
* Current Varint implementation is unsigned LEB128, reading the least significant bytes first. Impl. adapted from https://github.com/topas/VarintBitConverter which references https://developers.google.com/protocol-buffers/docs/encoding#varints * Update the root README to reflect current implementation * Add unit tests for VarintTranslator
* Update README deck code to reflect current sorting strategy. The set/faction orders were flipped. * Add to unit test data file
3da11f4
to
79386ef
Compare
This PR has a couple of changes, split out across commits. Happy to drop/split out any commits if felt PR is too big.
VarintTranslator
methodsUnitTest1.cs
LoRDeckCodes_Tests.csproj
ProjectReference (s/Lor/LoR/
)using
directivesNewtonsoft.Json
package*.csproj
spacing consistentnetcoreapp
to v3.1netcoreapp2.0
used in both projects. This version is EOL. Update the LTS version 3.1(2022-12-03)
warning NETSDK1138: The target framework 'netcoreapp2.0' is out of support and will not receive security updates in the future.
.NET 6
, but figured this was the smallest jump https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core