Add doublechecked::Roaring64Map + tests, fix issues found by it #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of both doublechecked::Roaring64Map and the tests are mostly copied from the 32-bit version. I ran clang-format on the newly added code in tests/cpp_random_unit.cpp. I also added a statement to print the random seed, to reproduce failures only reproduced by specific seeds.
Adding this random test surfaced a few issues: