Improve the code readability of Roaring64Map::printf() and Roaring64Map::toString() #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
force-pushed
the
kosak_improve-printf
branch
from
1a322bc to
7a27533
Compare
SLieve
reviewed
Nov 8, 2022
kosak
force-pushed
the
kosak_improve-printf
branch
from
bc11d6a to
adc754c
Compare
lemire
reviewed
Nov 9, 2022
|
I am going to merge this. Obviously we can improve the implementation, and it is possible that the new code is slower. However, if we are concerned about it, then it should be handled by a separate PR (since we don't even have benchmarks for those functions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the readability of the implementations of
Roaring64Map::printf()andRoaring64Map::toString(). Additionally provide a publicprintToSink()member so that callers can stream to their own custom sinks. Also add some unit tests. The functionality is unchanged.