Rework the insert/remove_range functions with RangeBounds #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
changed the title
Urhengulas
reviewed
Apr 1, 2021
tomjw64
reviewed
Apr 1, 2021
Kerollmops
force-pushed
the
insert-remove-range-bounds
branch
from
a5e5465 to
fa8b38a
Compare
5 tasks
Kerollmops
force-pushed
the
insert-remove-range-bounds
branch
from
14376a0 to
b27dc3c
Compare
|
Hey @oliverdding, Could you please do a last review before I merge that? It is safe enough as you and I added more tests, but can you take a look at the files, please? Just to make sure my rebasing didn't break anything? |
|
Hi @Kerollmops It's my pleasure. |
oliverdding
reviewed
Oct 20, 2021
|
Thank you very much for your review @oliverdding, I have applied your advice and will merged just after your last review 🫖 |
Kerollmops
added
the
breaking
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
|
Thank you for the last review! |
|
Build succeeded: |
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
92: Rework the insert/remove_range functions with RangeBounds r=Kerollmops a=Kerollmops This PR fixes RoaringBitmap#5 by reworking the `Bitmap::insert_range` and `Bitmap::remove_range` functions to accept any type that implement [the `RangeBounds` trait](https://doc.rust-lang.org/nightly/core/ops/trait.RangeBounds.html). Note that it is a breaking change and therefore involves bumping the crate version carefully. The current version of all these functions was accepting an [exclusive `Range<u64>`](https://doc.rust-lang.org/nightly/core/ops/struct.Range.html) to let user define all possible integers in the range `0` to `u32::MAX`, but as it is an exclusive range, a `u64` was required. `@josephglanville,` could you please take a look at this PR? When you got time 😃 Co-authored-by: Clément Renault <[email protected]> Co-authored-by: oliverdding <[email protected]> Co-authored-by: Kerollmops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5 by reworking the
Bitmap::insert_rangeandBitmap::remove_rangefunctions to accept any type that implement theRangeBoundstrait. Note that it is a breaking change and therefore involves bumping the crate version carefully.The current version of all these functions was accepting an exclusive
Range<u64>to let user define all possible integers in the range0tou32::MAX, but as it is an exclusive range, au64was required.@josephglanville, could you please take a look at this PR? When you got time 😃