Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JsonFormatter #829

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Oct 7, 2024

This is useful when other programs wants to read the output data.

@Ocramius Ocramius added this to the 8.10.0 milestone Oct 7, 2024
This is useful when other programs wants to read the output data
@Nyholm
Copy link
Contributor Author

Nyholm commented Oct 7, 2024

Thank you for the quick review and the suggestions.

I've updated the PR accordingly.

@Ocramius Ocramius requested a review from asgrim October 8, 2024 16:43
Copy link
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it, and well defined too with a schema 💯

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 then, thanks @Nyholm!

@Ocramius Ocramius self-assigned this Oct 8, 2024
@Ocramius Ocramius merged commit 42af3cd into Roave:8.10.x Oct 8, 2024
12 checks passed
@Ocramius Ocramius changed the title Add support for JsonFormatter Add support for JsonFormatter Oct 8, 2024
@Nyholm Nyholm deleted the json-formatter branch October 8, 2024 20:38
@Nyholm
Copy link
Contributor Author

Nyholm commented Oct 8, 2024

Thank you for merging

@Ocramius
Copy link
Member

Ocramius commented Oct 8, 2024

Is also released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants