Merge pull request #1216 from kukulich/ast

Removed `ReflectionProperty::getAst()` to prevent memory leaks
Roave · Sep 22, 2022 · 054b4a3 · 054b4a3
2 parents e1901bf + d44ff48
commit 054b4a3
Show file tree

Hide file tree

Showing 5 changed files with 232 additions and 127 deletions.
diff --git a/src/Reflection/ReflectionClass.php b/src/Reflection/ReflectionClass.php
@@ -886,14 +886,10 @@ static function (ReflectionClass $ancestor) use ($filter): array {
                     ),
                     ...array_map(
                         function (ReflectionClass $trait) use ($filter) {
-                            return array_map(fn (ReflectionProperty $property): ReflectionProperty => ReflectionProperty::createFromNode(
-                                $this->reflector,
-                                $property->getAst(),
-                                $property->getPositionInAst(),
-                                $property->getDeclaringClass(),
-                                $this,
-                                $property->isPromoted(),
-                            ), $trait->getProperties($filter));
+                            return array_map(
+                                fn (ReflectionProperty $property): ReflectionProperty => ReflectionProperty::withImplementingClass($property, $this),
+                                $trait->getProperties($filter),
+                            );
                         },
                         $this->getTraits(),
                     ),