Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReflectionEnum::__construct() can be private #1139

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

kukulich
Copy link
Collaborator

No description provided.

@kukulich kukulich changed the base branch from 5.7.x to 6.0.x June 26, 2022 10:06
@Ocramius Ocramius added this to the 6.0.0 milestone Jun 26, 2022
@kukulich kukulich marked this pull request as ready for review June 26, 2022 10:32
@kukulich kukulich mentioned this pull request Jun 26, 2022
4 tasks
@kukulich kukulich force-pushed the constructors branch 2 times, most recently from 8934134 to d972c7a Compare September 13, 2022 09:17
@Ocramius Ocramius self-assigned this Sep 13, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kukulich!

src/Reflection/ReflectionClass.php Outdated Show resolved Hide resolved
@Ocramius
Copy link
Member

Thanks @kukulich!

Not waiting for CI, since what was left was just a CS issue :)

@Ocramius Ocramius merged commit 4ed52c8 into Roave:6.0.x Sep 13, 2022
@kukulich kukulich deleted the constructors branch September 30, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants