Improved mutation score #1221
Merged
Improved mutation score #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal() and without mutants
Ocramius
reviewed
Sep 23, 2022
Ocramius
reviewed
Sep 23, 2022
| @@ -25,12 +24,12 @@ public function __construct( | |||
| IntersectionType $type, | |||
| ) { | |||
| /** @var non-empty-list<ReflectionNamedType> $types */ | |||
There was a problem hiding this comment.
In theory not needed? Should be inferred 🤔
There was a problem hiding this comment.
ERROR: MixedPropertyTypeCoercion - src/Reflection/ReflectionIntersectionType.php:33:24 - $this->types expects 'non-empty-list<Roave\BetterReflection\Reflection\ReflectionNamedType>', parent type `array<array-key, Roave\BetterReflection\Reflection\ReflectionNamedType>` provided (see https://psalm.dev/196)
$this->types = $types;
There was a problem hiding this comment.
We just did an array_map() with a closure with well defined return types, and it failed inference? :O
Ocramius
reviewed
Sep 23, 2022
| @@ -28,12 +27,12 @@ public function __construct( | |||
| UnionType $type, | |||
| ) { | |||
| /** @var non-empty-list<ReflectionNamedType|ReflectionIntersectionType> $types */ | |||
There was a problem hiding this comment.
ERROR: MixedPropertyTypeCoercion - src/Reflection/ReflectionUnionType.php:36:24 - $this->types expects 'non-empty-list<Roave\BetterReflection\Reflection\ReflectionIntersectionType|Roave\BetterReflection\Reflection\ReflectionNamedType>', parent type `array<array-key, Roave\BetterReflection\Reflection\ReflectionIntersectionType|Roave\BetterReflection\Reflection\ReflectionNamedType>` provided (see https://psalm.dev/196)
$this->types = $types;
Ocramius
reviewed
Sep 23, 2022
| ); | ||
| } | ||
|
|
||
| return $parameters; | ||
| } | ||
|
|
||
| /** @param list<Node\Param> $parameterNodes */ | ||
| private function isParameterOptional(array $parameterNodes, ParamNode $parameterNode, int $parameterIndex): bool | ||
| private function isParameterOptional(array $parameterNodes, int $parameterIndex): bool |
There was a problem hiding this comment.
Somehow, roave/backward-compatibility-check picked up this change:
[BC] CHANGED: The parameter $parameterNode of Roave\BetterReflection\Reflection\ReflectionFunctionAbstract#isParameterOptional() changed from PhpParser\Node\Param to a non-contravariant int
[BC] CHANGED: The parameter $parameterNode of Roave\BetterReflection\Reflection\ReflectionFunctionAbstract#isParameterOptional() changed from PhpParser\Node\Param to int
[BC] CHANGED: Parameter 1 of Roave\BetterReflection\Reflection\ReflectionFunctionAbstract#isParameterOptional() changed name from parameterNode to parameterIndex
Ignoring for now, just an interesting bug though: possibly due to abstract class not having many filters on method visibility analysis.
Ocramius
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.