Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default PHP parser is not memoizing to prevent memory leaks #1230

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Default PHP parser is not memoizing to prevent memory leaks #1230

merged 1 commit into from
Sep 24, 2022

Conversation

kukulich
Copy link
Collaborator

No description provided.

@kukulich
Copy link
Collaborator Author

Before: https://github.com/Roave/BetterReflection/actions/runs/3116067373/jobs/5053577987

Time: 00:52.281, Memory: 2.45 GB

After: https://github.com/Roave/BetterReflection/actions/runs/3116919892/jobs/5055178445

Time: 01:02.807, Memory: 1.33 GB

@kukulich kukulich marked this pull request as ready for review September 24, 2022 04:15
Ocramius
Ocramius approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible 👍

@Ocramius Ocramius self-assigned this Sep 24, 2022
@Ocramius Ocramius added this to the 6.0.0 milestone Sep 24, 2022
@Ocramius Ocramius merged commit c0248d1 into Roave:6.0.x Sep 24, 2022
@kukulich kukulich deleted the parser branch September 30, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
BC break enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kukulich @Ocramius