ReflectionClass::getConstant(), getConstants() and getImmediateConstants() more consistent with methods and properties methods
#1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts() return ReflectionClassConstant instance Methods getReflectionConstant(), getReflectionConstants() and getImmediateReflectionConstants() were removed
Ocramius
reviewed
Sep 24, 2022
| */ | ||
| public function getConstant(string $name): string|int|float|bool|array|null | ||
| public function getImmediateConstants(int|null $filter = null): array |
There was a problem hiding this comment.
If we only stick to int $filter, we should document its bitmask type precisely
There was a problem hiding this comment.
@Ocramius Can I prepare everything in next PR? I will change it for methods and properties as well.
| * | ||
| * @return scalar|array<scalar>|null | ||
| * @return array<string, ReflectionClassConstant> indexed by name |
| * @return array<string, ReflectionClassConstant> indexed by name | ||
| */ | ||
| public function getImmediateReflectionConstants(): array | ||
| public function getConstant(string $name): ReflectionClassConstant|null |
There was a problem hiding this comment.
We should only accept non-empty-string as name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReflectionClassConstantinstances