Improved return type of Reflection*::getModifiers()
#1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Sep 25, 2022
| @@ -25,3 +25,6 @@ parameters: | |||
| - | |||
| message: '#Call to an undefined method PhpParser\\NodeVisitorAbstract::(getNode|setConstantName)\(\)#' | |||
| path: src/SourceLocator/Type/AutoloadSourceLocator.php | |||
| - | |||
| message: '#Method Roave\\BetterReflection\\Reflection\\ReflectionClass::computeModifiers\(\) never returns \d+ so it can be removed from the return type#' | |||
There was a problem hiding this comment.
There's a grammar error here on returns /cc @ondrejmirtes
src/Reflection/ReflectionClass.php
Outdated
| @@ -332,6 +326,7 @@ private function createMethodsFromTrait(ReflectionMethod $method): array | |||
|
|
|||
| if (array_key_exists($methodHash, $this->traitsData['modifiers'])) { | |||
| // PhpParser modifiers are compatible with PHP reflection modifiers | |||
| /** @var int-mask-of<ReflectionMethodAdapter::IS_*> $methodModifiers */ | |||
There was a problem hiding this comment.
Cherry-picked two commits from my next PR.
Psalm can infer the type now, PHPStan cannot.
8f89aae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant should be removed in a4e5618