Detection of interface extends circular references

src/Reflection/ReflectionClass.php

@@ -1600,23 +1600,32 @@ private function getCurrentClassImplementedInterfacesIndexedByName(): array
     /**
      * This method allows us to retrieve all interfaces parent of the this interface. Do not use on class nodes!
      *
+     * @param list<class-string> $interfaceClassNames
+     *
      * @return array<class-string, ReflectionClass> parent interfaces of this interface
      *
      * @throws NotAnInterfaceReflection
      */
-    private function getInterfacesHierarchy(): array
+    private function getInterfacesHierarchy(array &$interfaceClassNames = []): array
     {
         if (! $this->isInterface) {
             throw NotAnInterfaceReflection::fromReflectionClass($this);
         }
 
+        $interfaceClassName = $this->getName();
+        if (in_array($interfaceClassName, $interfaceClassNames, true)) {
+            throw CircularReference::fromClassName($interfaceClassName);
+        }
+
+        $interfaceClassNames[] = $interfaceClassName;
+
         /** @var array<class-string, self> $interfaces */
         $interfaces = array_merge(
-            [$this->getName() => $this],
+            [$interfaceClassName => $this],
             ...array_map(
                 fn (string $interfaceClassName): array => $this->reflector
                     ->reflectClass($interfaceClassName)
-                    ->getInterfacesHierarchy(),
+                    ->getInterfacesHierarchy($interfaceClassNames),
                 $this->implementsClassNames,
             ),
         );

test/unit/Fixture/InvalidInterfaceParents.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Roave\BetterReflectionTest\Fixture\InvalidInterfaceParents;
+
+interface InterfaceExtendsSelf extends InterfaceExtendsSelf {}
+
+interface Interface1 extends Interface2 {}
+interface Interface2 extends Interface1 {}
+interface Interface3 extends Interface2 {}

test/unit/Reflection/ReflectionClassTest.php

@@ -1731,6 +1731,32 @@ public function testGetInterfacesWillConsiderInterfaceInheritanceLevels(): void
         }
     }
 
+    /** @return list<array{0: string}> */
+    public function interfaceExtendsCircularReferencesProvider(): array
+    {
+        return [
+            ['Roave\\BetterReflectionTest\\Fixture\\InvalidInterfaceParents\\InterfaceExtendsSelf'],
+            ['Roave\\BetterReflectionTest\\Fixture\\InvalidInterfaceParents\\Interface1'],
+            ['Roave\\BetterReflectionTest\\Fixture\\InvalidInterfaceParents\\Interface2'],
+            ['Roave\\BetterReflectionTest\\Fixture\\InvalidInterfaceParents\\Interface3'],
+        ];
+    }
+
+    /** @dataProvider interfaceExtendsCircularReferencesProvider */
+    public function testGetInterfacesFailsWithCircularReferences(string $className): void
+    {
+        $reflector = new DefaultReflector(new SingleFileSourceLocator(
+            __DIR__ . '/../Fixture/InvalidInterfaceParents.php',
+            $this->astLocator,
+        ));
+
+        $class = $reflector->reflectClass($className);
+
+        $this->expectException(CircularReference::class);
+
+        $class->getInterfaces();
+    }
+
     public function testIsInstance(): void
     {
         // note: ClassForHinting is safe to type-check against, as it will actually be loaded at runtime