Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: top level transformations and remapping #1869

Merged
merged 32 commits into from
Jul 3, 2024
Merged

Feat: top level transformations and remapping #1869

merged 32 commits into from
Jul 3, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Jun 30, 2024 •
edited
Loading

Based on the discussion #1615

⚠️ Only transformations to another object will be allowed

Todo:

  • handle output schema transformations in the documentation ✅
    • done by adding ZodObject::remap() to the distributed Zod plugin
  • more tests ✅
  • documentation ✅

@RobinTail RobinTail added enhancement New feature or request refactoring The better way to achieve the same result labels Jun 30, 2024
Repository owner deleted a comment from coveralls-official bot Jun 30, 2024
Repository owner deleted a comment from coveralls-official bot Jun 30, 2024
Repository owner deleted a comment from coveralls-official bot Jun 30, 2024
Repository owner deleted a comment from coveralls-official bot Jun 30, 2024
Repository owner deleted a comment from coveralls-official bot Jun 30, 2024
@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 99.915% (-0.09%) from 100.0%
when pulling 070453b on allow-top-level-transformations
into 6a356fd on master.

Repository owner deleted a comment from coveralls-official bot Jul 2, 2024
Repository owner deleted a comment from coveralls-official bot Jul 2, 2024
Repository owner deleted a comment from coveralls-official bot Jul 2, 2024
@RobinTail RobinTail marked this pull request as ready for review July 2, 2024 19:30
@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 5f01891 on allow-top-level-transformations
into 6a356fd on master.

@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling d120400 on allow-top-level-transformations
into 6a356fd on master.

@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 2ac86f8 on allow-top-level-transformations
into 6a356fd on master.

RobinTail
RobinTail commented Jul 2, 2024
View reviewed changes
src/mapping-helpers.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jul 2, 2024
View reviewed changes
src/mapping-helpers.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jul 2, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 0de077a on allow-top-level-transformations
into 6a356fd on master.

@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling a5de976 on allow-top-level-transformations
into 6a356fd on master.

@RobinTail RobinTail mentioned this pull request Jul 2, 2024
Merged
@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 5cabf3e on allow-top-level-transformations
into 6a356fd on master.

@RobinTail RobinTail changed the title Feat: top level transformations Feat: top level transformations and remapping Jul 3, 2024
@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 9dd626a on allow-top-level-transformations
into 6a356fd on master.

@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 4accc62 on allow-top-level-transformations
into 6a356fd on master.

@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 61aa062 on allow-top-level-transformations
into 6a356fd on master.

RobinTail
RobinTail commented Jul 3, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok now

@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 0b534ac on allow-top-level-transformations
into 6a356fd on master.

@RobinTail
Copy link
Owner Author

✅ QA passed

@RobinTail RobinTail merged commit 2d2c6e2 into master Jul 3, 2024
12 checks passed
@RobinTail RobinTail deleted the allow-top-level-transformations branch July 3, 2024 08:31
RobinTail added a commit that referenced this pull request Jul 3, 2024
@RobinTail
Feat: Partial mapping and passthrough support for .remap() (#1878)
a8d1ca3 
Addition to #1869 

Todo:
- also handle/proxy passthrough in pipe (`this._def.unknownKeys`) ✅ 
- handle explicit `undefined` ✅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request miracle Mysterious events are happening here refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail