Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Feature/general grid type #1404

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

Florisheinen1
Copy link
Member

@Florisheinen1 Florisheinen1 commented Jun 20, 2022

Comments for the reviewer

This PR makes use of the new Grid type and removes a few unused variables.
This is of course dependent on the PR in utils

This will be a build-up for a refactor PR of the current Field class in AI

Pre pull request checklist:

Code Quality
  • Is the code is understandable and easy to read
  • Changes to the code comply with set clang-format rules
  • No use of manual memory control (e.g new/malloc/colloc etc)
  • Are (only) smart pointers used?
Testing
  • All tests are passing.
  • I added new / changed existing tests to reflect code changes (state why not otherwise!)
  • I tested my changes manually (Describe how, to what extent etc.)
Commit Messages
  • Commit message is saying what has been changed, why it was changed? Remember other developers might not know
    what the problem you are fixing was. Note also negative decision (e.g., why did you not do particular thing)
    TLDR: Commit message are comprehensive
  • Commit messages follows the rules of https://chris.beams.io/posts/git-commit/

@JAndringa JAndringa requested review from JAndringa and removed request for alexander-de-ranitz September 19, 2022 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant