Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Modernize advice regarding PYTHONPATH #13660

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jul 9, 2020

This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

+@jamiesnape for feature review, please.

Any reason to delay merging this until Homebrew/homebrew-core#57654 is done? Seems OK to merge now, to me.

Copy link
Contributor

@jamiesnape jamiesnape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

No reason to delay.

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @jamiesnape)

@jwnimmer-tri
Copy link
Collaborator Author

+@sammy-tri for platform review per schedule, please.

Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: (didn't verify, trusting the feature reviewer on mac behavior)

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees sammy-tri(platform),jamiesnape (waiting on @jamiesnape)

@sammy-tri sammy-tri merged commit e24782e into RobotLocomotion:master Jul 9, 2020
@jwnimmer-tri jwnimmer-tri deleted the doc-macos-python-path branch July 9, 2020 15:20
@jamiesnape jamiesnape removed their assignment Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants