Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Objective to Cost #2649

Merged
merged 5 commits into from
Jun 28, 2016
Merged

Conversation

naveenoid
Copy link
Contributor

@naveenoid naveenoid commented Jun 26, 2016

All usages of "Objective" refactored to "Cost" to fit with #2639

+@sammy-tri Feature review
+@sherm1 Platform review


This change is Reviewable

@sherm1
Copy link
Member

sherm1 commented Jun 26, 2016

Whoops -- sorry, I take that back @naveenoid. Build problems, for example:

18:45:30 /home/ubuntu/workspace/experimental/9111c4bf/drake/solvers/SnoptSolver.cpp:195:47: error: no member named 'generic_objectives' in 'drake::solvers::OptimizationProblem'
18:45:30   for (auto const& binding : current_problem->generic_objectives()) {
18:45:30                              ~~~~~~~~~~~~~~~  ^
18:45:30 /home/ubuntu/workspace/experimental/9111c4bf/drake/solvers/IpoptSolver.cpp:406:42: error: no member named 'generic_objectives' in 'drake::solvers::OptimizationProblem'
18:45:30     for (auto const& binding : problem_->generic_objectives()) {
18:45:30                                ~~~~~~~~  ^
18:45:31 1 error generated.

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@naveenoid
Copy link
Contributor Author

ready for review.

@naveenoid
Copy link
Contributor Author

@drake-jenkins-bot retest this please

@sammy-tri
Copy link
Contributor

Reviewed 6 of 6 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


drake/solvers/NloptSolver.cpp, line 46 [r2] (raw file):

// This function meets the signature requirements for nlopt::vfunc as
// described in
// http://ab-initio.mit.edu/wiki/index.php/NLopt_C-plus-plus_Reference#ObjectCostive_function

The URL for the NLopt documentation should not change.


Comments from Reviewable

@sammy-tri
Copy link
Contributor

:lgtm:


Review status: 7 of 8 files reviewed at latest revision, all discussions resolved.


drake/solvers/NloptSolver.cpp, line 46 [r2] (raw file):

Previously, sammy-tri wrote…

The URL for the NLopt documentation should not change.

Thanks!

Comments from Reviewable

@sammy-tri
Copy link
Contributor

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@david-german-tri
Copy link
Contributor

@sherm1 FYI, you can use :lgtm_cancel: in situations like this!


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@sherm1
Copy link
Member

sherm1 commented Jun 27, 2016

Thanks, @david-german-tri -- I'll :lgtm_cancel: until the build finishes.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@sherm1
Copy link
Member

sherm1 commented Jun 27, 2016

Reviewed 2 of 2 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sherm1
Copy link
Member

sherm1 commented Jun 28, 2016

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sherm1 sherm1 merged commit 5b054d5 into RobotLocomotion:master Jun 28, 2016
@naveenoid naveenoid deleted the dev/rebaseCost branch June 29, 2016 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants