Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ASR & TTS api to rai core #309

Open
maciejmajek opened this issue Nov 7, 2024 · 0 comments
Open

Move ASR & TTS api to rai core #309

maciejmajek opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@maciejmajek
Copy link
Member

maciejmajek commented Nov 7, 2024

Is your feature request related to a problem? Please describe.
Currently, ASR and TTS features are implemented in RAI_ASR and RAI_TTS ROS 2 packages. This makes it hard to test these features outside of ROS 2.

Describe the solution you'd like
The api should be moved to the core rai package.
Benefits:

  • Easier testing
  • Code reusability (RAI_ASR, RAI_TTS packages, streamlit configurator script, pytest tests)
  • Making developing interruptible conversation module easier (No ROS 2 abstractions between ASR, TTS, and generator (llm))

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@maciejmajek maciejmajek added the enhancement New feature or request label Nov 7, 2024
@maciejmajek maciejmajek self-assigned this Nov 14, 2024
@boczekbartek boczekbartek added ux User experience related issue and removed ux User experience related issue labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants