Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[FIX] Support Webpack relative output path #292

Merged
merged 1 commit into from
Sep 16, 2019
Merged

[FIX] Support Webpack relative output path #292

merged 1 commit into from
Sep 16, 2019

Conversation

renatobecker-zz
Copy link
Contributor

@renatobecker-zz renatobecker-zz commented Sep 13, 2019 •
edited
Loading

Closes #289
Closes #290

When the Rocket.Chat runs in a subfolder, the Livechat chunk files aren't loaded because of the current Webpack config.

I'm sharing a few screenshots showing the test of running Rocket.Chat in a subfolder:

Screen Shot 2019-09-16 at 13 13 35

Old index.html:

Screen Shot 2019-09-16 at 13 14 50

Screen Shot 2019-09-16 at 13 14 59

New index.html(relative path):

Screen Shot 2019-09-16 at 13 22 50

Screen Shot 2019-09-16 at 13 22 55

Screen Shot 2019-09-16 at 13 23 04

@renatobecker-zz renatobecker-zz added bug Something isn't working enhancement New feature or request labels Sep 13, 2019
@ggazzo ggazzo changed the title Support Webpack relative output path [FIX] Support Webpack relative output path Sep 16, 2019
@ggazzo ggazzo merged commit 3663e68 into dev Sep 16, 2019
@ggazzo ggazzo deleted the support-relativa-path-webpack-build branch September 16, 2019 16:40
@ggazzo ggazzo mentioned this pull request Oct 14, 2019
Merged
@rafaelblink rafaelblink mentioned this pull request Oct 23, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@tassoevan tassoevan Awaiting requested review from tassoevan

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@renatobecker-zz @ggazzo @renatobecker