[OP-152] Rename btn-delete to btn-destructive #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
From a semantic perspective, delete doesn't match other buttons. The original reason for the naming was to convey more intention when using it.
destructive
is just as semantic, but allows for broader use cases like closing an account (that may be recoverable)What Changed
btn-destructive
classbtn-delete
so as to not cause breaking changesSanity Check
[ ] Have you updated any usage of changed tokens?[ ] Have you updated the dependency graph with any component changes?[ ] Do you need to update the package version?Screenshots