Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP-152] Rename btn-delete to btn-destructive #222

Conversation

Jeremy-Walton
Copy link
Member

Why?

From a semantic perspective, delete doesn't match other buttons. The original reason for the naming was to convey more intention when using it. destructive is just as semantic, but allows for broader use cases like closing an account (that may be recoverable)

What Changed

  • Add btn-destructive class
  • Update documentation terminology
  • Retail btn-delete so as to not cause breaking changes

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • [ ] Do you need to update the package version?

Screenshots

Screenshot 2024-02-16 at 2 37 36 PM

@Jeremy-Walton Jeremy-Walton added documentation Improvements or additions to documentation Components Changes to a component labels Feb 16, 2024
@Jeremy-Walton Jeremy-Walton added this to the v1.0.0 Release milestone Feb 16, 2024
@Jeremy-Walton Jeremy-Walton self-assigned this Feb 16, 2024
Copy link
Collaborator

@scriswell scriswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeremy-Walton I'm glad you made this backwards compatible with the older name.

@Jeremy-Walton Jeremy-Walton merged commit 0473616 into main Feb 16, 2024
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the op-152-is-there-a-reason-for-the-discrepancy-between-the-danger branch February 16, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Components Changes to a component documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

3 participants