Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup documentation on Addons.mdx ScaleOverriding.mdx and Tokens.mdx #232

Merged
merged 1 commit into from
Jul 31, 2024
Merged

cleanup documentation on Addons.mdx ScaleOverriding.mdx and Tokens.mdx #232

merged 1 commit into from
Jul 31, 2024

Conversation

yawnybear
Copy link
Contributor

@yawnybear yawnybear commented Jul 30, 2024 •
edited
Loading

Documentation Cleanup

TR #XXX

Why?

Resolve mistypes found within Addons.mdx ScaleOverriding.mdx and Tokens.mdx

What Changed

What changed in this PR?

  • Changed optic to optics in Addons.mdx
  • Changed css to CSS in ScaleOverriding.mdx
  • Altered spelling of intended in Tokens.mdx

Sanity Check

  • Have you updated any usage of changed tokens? No.
  • Have you updated the docs with any component changes? No.
  • Have you updated the dependency graph with any component changes? No.
  • Have you run linters? No.
  • Have you run prettier? No.
  • Have you tried building the css? No.
  • Have you tried building storybook? Yes (Is this the correct answer?)
  • Do you need to update the package version? No (?)

Screenshots

If any UI changes need to be shown off, please add screenshots here.

@yawnybear yawnybear requested a review from Jeremy-Walton July 30, 2024 16:33
@Jeremy-Walton Jeremy-Walton added the documentation Improvements or additions to documentation label Jul 30, 2024
Jeremy-Walton
Jeremy-Walton approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@Jeremy-Walton Jeremy-Walton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should run yarn sanity-check to run all the linters and build things.

If that runs no issue, then you are good to merge!

@yawnybear yawnybear merged commit ea7a897 into main Jul 31, 2024
1 check passed
@yawnybear yawnybear deleted the documentation-cleanup branch July 31, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeremy-Walton Jeremy-Walton Jeremy-Walton approved these changes

Assignees

@yawnybear yawnybear

Labels
documentation Improvements or additions to documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yawnybear @Jeremy-Walton