LinearBar, but vertical?

[dervur]

Hello there,
I was wondering, is there a way to create a modulator`, and when you set the slider style to be "LinearBar" to have it change values vertically instead of horizontally?
I can see from the solution that if I search for "LinearBar", in different source code there appear also a "LinearBarVertical", but it does not appear in the modulators? Unless I'm missing something.
Do I need to modify the code to enable it?

Should I just add a case for it in CtrlrComponentTypeManager.cpp (line 191)? Because there is code for it in other sections, but I do not know if this will be enough to make it work (just adding an extra case). Or if it needs extra work somewhere else. I can see a linear bar vertical existing in the look and feel.

Thanks to anybody who will help. If nobody replies I will try to do a build with just a case added to that function and see if it works and report if it works or not within this week, I was more asking to know if anybody already knows about this before I went on and tried it myself.

[dervur]

I saw just now this discussion #627. So, I know I can do this in LUA now. But if nobody else tried I will try to add that case for sliderStyleToString and sliderStringToStyle and see if it works fine...

[dervur]

Ok, I solved the issue, I am editing this original comment because the reasons why the following was working was due to me not building CtrlrX properly. Once I did it, it began working.

• in CtrlrIDs.xml in line 238, I added it after LinearBar as LinearBarVertical
• in CtrlrComponentTypeManager.h I added LinearBarVertical = Slider::LinearBarVertical, in line 17
• in CtrlrComponentTypeManager.cpp I added in line 224 the following:

else if (s == "LinearBarVertical")
		return LinearBarVertical;

and in line 201 the following:

case Slider::LinearBarVertical:
			return "LinearBarVertical";

This will allow you to use the linear bar vertically.

[dervur]

@damiensellier just tagging you here in case you want to add this in future CtrlrX iterations.

[damiensellier]

Hi, that's cool, I remember there was other style of sliders missing from the JUCE library.
I'll add them for the next version.

Damien

REF : damiensellier#67

[dervur]

On a side note, both LinearBar (the horizontal one), and LinearBarVertical do not update font type nor size. I'll have a look in the week to the code to see if I can find the issue, but I wanted to report the bug (if you didn't already know). It seems the only thing that you can change of the font is only the colour.
Just a few examples:
Font size 12 (even the font type should be different based on what I selected, what it shows in the screenshots is the default one):

Font size 20:

Another value font:

But colour changes go through:

Even bold, italic and all those settings do not get updated. I tried saving and closing, and then reopening but it does not change as it does with other types of slide. I tried both uiSlider and uiFixedSlider, they all present the issue.

If I find a solution, I will write it in this discussion.

Edit: uiFixedImageSlider and uiImageSlider do not have this issue and the font updates correctly.

[damiensellier]

True, it's missing from when Ctrlr was updated to JUCE v5 or v6.
all the LnF for sliders is pretty complex especially because of the save/restore process from panel properties.
I really struggled with that I remember.
The font, justification, spacing should be easy though to add.
I'll check how it was working in the 5.3.198 version, I have the code source somewhere for reference.

Those parameters should apply from this line of code :

https://github.com/damiensellier/CtrlrX/blob/e8f5cffc10d2bd8fa3c682370ad975b421111589/Source/UIComponents/CtrlrComponents/Sliders/CtrlrSlider.cpp#L291

 else if (property == Ids::uiSliderIncDecButtonColour
             || property == Ids::uiSliderIncDecTextColour
             || property == Ids::uiSliderValueFont
             || property == Ids::uiSliderValueTextJustification)
    {
        
        if ( getProperty(Ids::uiSliderLookAndFeel) == "V3"
            || getProperty(Ids::uiSliderLookAndFeel) == "V2"
            || getProperty(Ids::uiSliderLookAndFeel) == "V1" )
        {
            ctrlrSlider.setLookAndFeel (nullptr); // Warning, it resets the LnF on loading
            ctrlrSlider.setLookAndFeel (&lf); // V5.6.28 and before
        }
        else
        {
            //ctrlrSlider.setLookAndFeel (nullptr); // Warning, it resets the LnF on loading
            //ctrlrSlider.setLookAndFeel (&lfV4); // V5.6.28+
        }
        setProperty(Ids::uiSliderLookAndFeelIsCustom, true); // Locks the component custom colourScheme
    }

the lookandfeel needs to be refreshed with lookandfeelchanged(). I need to check that for sure.

But I don't remember exactly, there was a tricky part about the slider being able to be updated right away but the box with the values not... those being actually 2 different components.

[dervur]

I'll have a look maybe later. Since it works for uiFixedImageSlider and uiImageSlider I think there should be some reference indication for this purpose.
In the panel I was doing in reality only uiFixedImageSlider and uiImageSlider are enough as they are as I didn't want the bar to fill when the value changes, I only wanted a slider that would allow me to change values by clicking at the number. So I think for the time being that can be a solution as well for some applications.

[damiensellier]

I remember the following part if uncommented was actually updating the style of the text, but it was breaking something when you loaded that panel. That's why I commented :

            //ctrlrSlider.setLookAndFeel (nullptr); // Warning, it resets the LnF on loading
            //ctrlrSlider.setLookAndFeel (&lfV4); // V5.6.28+

setLookAndFeel (&lfV4) is the part where the actual value box style is called and updated.

The order of when you reset the LnF / update another one / assign it to the slider was actually a nightmare to manage. And since it takes 5-6 minutes to compile the app to see your change, this is when you have to sacrifice a whole night to fix it :)

I have some notes somewhere about all that. I opened an issue on CtrlrX : damiensellier#68

[damiensellier]

I'll try first by separating all those properties such as :

else if (property == Ids::uiSliderValueFont)
    {
        
        if ( getProperty(Ids::uiSliderLookAndFeel) == "V3"
            || getProperty(Ids::uiSliderLookAndFeel) == "V2"
            || getProperty(Ids::uiSliderLookAndFeel) == "V1" )
        {
            ctrlrSlider.setLookAndFeel (nullptr); // Warning, it resets the LnF on loading
            ctrlrSlider.setLookAndFeel (&lf); // V5.6.28 and before
        }
        else
        {
            ctrlrSlider.setLookAndFeel (nullptr); // Warning, it resets the LnF on loading
            ctrlrSlider.setLookAndFeel (&lfV4); // V5.6.28+
        }
        setProperty(Ids::uiSliderLookAndFeelIsCustom, true); // Locks the component custom colourScheme
    }

else if (property == Ids::uiSliderValueTextJustification)
    {
        
        if ( getProperty(Ids::uiSliderLookAndFeel) == "V3"
            || getProperty(Ids::uiSliderLookAndFeel) == "V2"
            || getProperty(Ids::uiSliderLookAndFeel) == "V1" )
        {
            ctrlrSlider.setLookAndFeel (nullptr); // Warning, it resets the LnF on loading
            ctrlrSlider.setLookAndFeel (&lf); // V5.6.28 and before
        }
        else
        {
            ctrlrSlider.setLookAndFeel (nullptr); // Warning, it resets the LnF on loading
            ctrlrSlider.setLookAndFeel (&lfV4); // V5.6.28+
        }
        setProperty(Ids::uiSliderLookAndFeelIsCustom, true); // Locks the component custom colourScheme
    }

etc