CtrlrMidiMessage crashing CtrlrX

[dervur]

Hello there,

I am trying to write a code to send sysex messages but I am having a bit of a struggle. For some reason creating a CtrlrMidiMessage makes the new version of CtrlrX crash.
My old panel that I was using with CtrlrMidiMessage still works, but if I copy the same exact code from there and I paste it in the one of the new panel it makes it crash.

Does anybody have any suggestion why is that?

This is my code:

sysex_Feedback = function(--[[ CtrlrModulator --]] mod, --[[ number --]] value, --[[ number --]] source)

    local sysex_message = {}
    -- SysEx header
    sysex_message[1] = 0xF0
    -- Yamaha ID
    sysex_message[2] = 0x43
    -- Device number
    sysex_message[3] = 0x10
    -- Group number high
    sysex_message[4] = 0x7F
    -- Group number low
    sysex_message[5] = 0x1C
    -- Model ID
    sysex_message[6] = 0x05
    -- Top Address (voice operator)
    sysex_message[7] = 0x31


    -- Get the name of the feedback fader that was selected
    local n=L(mod:getName())
    -- Table for selected OP in sysex message
    sysex_OP = {
    ["OP1 Feedback"] = 0x00,
    ["OP2 Feedback"] = 0x01,
    ["OP3 Feedback"] = 0x02,
    ["OP4 Feedback"] = 0x03,
    }
    -- Set the correct note based on which fader has been pressed
    for k,v in pairs(pad_notes)do
	    if k==n then
            -- Mid address (OP number)
            sysex_message[8] = v;
        end
    end

    -- Low address (Feedback type)
    sysex_message[9] = 0x14
    

    -- Get value of the selected modulator
    local value = panel:getModulatorByName(n):getValue()

    -- If value is greater than 0 then it is a sawtooth feedback...
    if  value > 0 then
        -- Feedback type value (sawtooth = 00)
        sysex_message[10] = 0x00
    -- ... otherwise it is a square feedback
    elseif value < 0 then
        -- Feedback type value (square = 01)
        sysex_message[10] = 0x01
        -- Invert sign of the value
        value = -value
    else
        return
    end

    -- SySex message end
    sysex_message[11] = 0xF7

    -- Send Feedback type SySex message [this is where it crashes, that is why I commented it for now]
    --panel:sendMidiMessageNow(CtrlrMidiMessage(sysex_message))

    -- Set the SySex message to send the fader level's
    -- Low address (Feedback Level)
    sysex_message[9] = 0x13
    -- Set feedback value
    sysex_message[10] = value

    -- Send Feedback level SySex message [same as above]
    --panel:sendMidiMessageNow(CtrlrMidiMessage(sysex_message))

end

The code from my old panel looks like:

    -- Create MIDI string
    local midiString = noteOn.." "..note.." "..vel;
    console(midiString)
    -- Create MIDI memory block
    local messageBlock = MemoryBlock(midiString)

    -- Create MIDI message for note On
    local messageOn = CtrlrMidiMessage(messageBlock:toHexString(1))

The way I tested this in the new code, since I do not have all the other variables is to create midiString as being "F7 F7", just to give it something. I went on commenting everthying and what makes my code crash is exactly the function CtrlrMidiMessage for some reason (while it is ok in the old panel...)

[damiensellier]

The difference between 5.6.26+ and the older 5.3.x ctrlr version is that midiMessage must be sent as a memoryBlock. The following code will cast a memoryblock from the message between parentheses (here from a LUA table) :
panel:sendMidiMessageNow(CtrlrMidiMessage(MemoryBlock(sysex_message)))

Let me know if it works with this syntax 🤓

[damiensellier]

panel:sendMidiMessageNow(CtrlrMidiMessage(MemoryBlock(sysex_message)))

[dervur]

For some reason that does not work and I need to take extra steps...
I had to break it down like this to make it work:

    -- Create MIDI memory block
    local messageBlock = MemoryBlock(sysex_message)
    -- Create Ctrlr MIDI message
    local message = CtrlrMidiMessage(messageBlock)
    -- Send Feedback type SySex message
    panel:sendMidiMessageNow(message)

But yeah that was the issue, I don't know why I can't make it all in one line as you suggested (cause it makes sense from a coding point of view), but it is what it is.
There was also a typo in my code from a copy-paste I made in the for loop, but last night I was too sleepy to realize that too lol.
Thank you very much for the help!

[damiensellier]

CtrlrMidiMessage() is CtrlrMidiMessage::CtrlrMidiMessage (const String& hexData)

So it must be stringified with hex inside.

maybe one of your element is not hex or the whole message is not a proper string

-- Set the correct note based on which fader has been pressed
    for k,v in pairs(pad_notes)do
	    if k==n then
            -- Mid address (OP number)
            sysex_message[8] = v;
        end
    end

the memoryblock must contain a table with hex inside {0xB0, 0x0C,...}

maybe v should be converted with tonumber() before being inserted to the table:
sysex_message[8] = tonumber(v);

try commenting to skip this part with the isertion of "v" to see if your message works first.

Or you could also try get the value as Integer : local value = panel:getModulatorByName(n):getIntValue()
Not sure about it though, one should be ok I guess.

[dervur]

I don't know what the issue is, but if I do it separately as I said it works. It doesn't work and crashes only if it is all in one line as you suggested, I don't know why, because it should work as you said.

About that for loops there was a typo there, it was supposed to be sysex_OP, not pad_notes (the table initialized just above), and that is hex.
Anyway, whatever the issue is I'm glad it solved it with those 3 lines.

[damiensellier]

to avoid crashing ctrlr with lua you can run pcall() to handle errors within your function :

-- create a function to throw an error
function myfunction ()
   n = n/nil
end

-- if no error, print success else display console() failure
if pcall(myfunction) then
   console("Success")
else
	console("Failure")
end

you would put your sendMidiMessageNow() in the success part, everything ouput should go there, if it fails you can just display a console() message.