Merge pull request #11 from ElGigi/stream

Allow to read into stream (create a memory stream)
RoyVoetman · Dec 1, 2020 · b300610 · b300610
2 parents 4f0525e + 3b220f1
commit b300610
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 29 deletions.
diff --git a/src/GitlabAdapter.php b/src/GitlabAdapter.php
@@ -147,7 +147,17 @@ public function read(string $path): string
      */
     public function readStream(string $path)
     {
-        throw new UnableToCreateStream(get_class($this).' Gitlab API does not support reading a file into a stream.');
+        if (false === ($fp = fopen('php://memory', 'r+'))) {
+            throw UnableToReadFile::fromLocation($path, 'Unable to open memory stream');
+        }
+
+        if (false === fwrite($fp, $this->read($path))) {
+            throw UnableToReadFile::fromLocation($path, 'Unable to write stream');
+        }
+
+        fseek($fp, 0);
+
+        return $fp;
     }
 
     /**

diff --git a/src/UnableToCreateStream.php b/src/UnableToCreateStream.php
diff --git a/tests/GitlabAdapterTest.php b/tests/GitlabAdapterTest.php
@@ -15,7 +15,6 @@
 use League\Flysystem\UnableToWriteFile;
 use RoyVoetman\FlysystemGitlab\Client;
 use RoyVoetman\FlysystemGitlab\GitlabAdapter;
-use RoyVoetman\FlysystemGitlab\UnableToCreateStream;
 
 class GitlabAdapterTest extends TestCase
 {
@@ -74,11 +73,12 @@ public function it_can_read_a_file()
     /**
      * @test
      */
-    public function it_throws_when_reading_a_file_into_a_stream()
+    public function it_can_read_a_file_into_a_stream()
     {
-        $this->expectException(UnableToCreateStream::class);
+        $stream = $this->gitlabAdapter->readStream('README.md');
 
-        $this->gitlabAdapter->readStream('README.md');
+        $this->assertIsResource($stream);
+        $this->assertEquals(stream_get_contents($stream, null, 0), $this->gitlabAdapter->read('README.md'));
     }
 
     /**