Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for PHP < 8.1 #16

Merged
merged 1 commit into from
Apr 28, 2024
Merged

feat: drop support for PHP < 8.1 #16

merged 1 commit into from
Apr 28, 2024

Conversation

Chris53897
Copy link

migrate PHPUnit 9 => 11
improve PHPDocs
Flip arguments for test-asserts.
Use recommended tests functions.

I can not run tests, because of missing GitLab instance to test against.

migrate PHPUnit 9 => 11
improve PHPDocs
@dolito
Copy link

dolito commented Mar 19, 2024

@Chris53897 just came accross this PR while searching ... maybe this can help you to test gitlab with docker-compose:

(it's from my personal test-instance)

  service-name-gitlab:
    # initial user will be: root
    # initial pass will be written in /etc/gitlab/initial_root_password

    # maybe you need to restart the container 1 or 2 times to get it running

    profiles:
      - test-gitlab
    image: gitlab/gitlab-ce
    environment:
      GITLAB_OMNIBUS_CONFIG: "
        external_url 'https://localhost';
        gitlab_rails['smtp_address'] = 'mailpit-or-mailhog-hostname';
        gitlab_rails['smtp_port'] = 1025;
        gitlab_rails['initial_root_password'] = 'password';
        gitlab_rails['display_initial_root_password'] = true;"
      # Add any other gitlab.rb configuration here, each on its own line
    ports:
      - "28443:443"
      - "28080:80"
      - "22022:22"
    volumes:
      - gitlab_data:/var/opt/gitlab
      - gitlab_logs:/var/log/gitlab
      - gitlab_config:/etc/gitlab

@Chris53897
Copy link
Author

thanks @dolito
I will try to find some time after my vaccation.
But i hope @RoyVoetman can help to verify this PR.

@RoyVoetman
Copy link
Owner

Sorry for the late reply,

I will run the tests for this PR in the upcoming weekend.

@RoyVoetman
Copy link
Owner

Thanks for the work you put into this PR Chris, all works, I will merge this and tag a new release.

@RoyVoetman RoyVoetman merged commit a583ad7 into RoyVoetman:master Apr 28, 2024
@RoyVoetman
Copy link
Owner

RoyVoetman commented Apr 28, 2024

@Chris53897
Copy link
Author

Chris53897 commented Apr 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants