Fix failing spec due to symbol_position defaults
#1078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address the unexpected behavior where `symbol_position: :before` has a different default compared to `symbol_position: :after`. The latter defaults to adding a space, which is expected based on the implementation in `determine_format_from_formatting_rules`. This commit does not alter the current behavior but fixes the failing spec to reflect the correct default behavior as per the implementation. Changing the default would introduce breaking changes, thus this commit only aims to make the spec pass. Note: Further investigation into the different default behaviors for `:before` and `:after` should be tracked in a separate issue. Fix RubyMoney#1075
|
No longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the unexpected behavior where
symbol_position: :beforehas a different default compared tosymbol_position: :after. The latter defaults to adding a space, which is expected based on the implementation indetermine_format_from_formatting_rules.This commit does not alter the current behavior but fixes the failing spec to reflect the correct default behavior as per the implementation. Changing the default would introduce breaking changes, thus this commit only aims to make the spec pass.
Note: Further investigation into the different default behaviors for
:beforeand:aftershould be tracked in a separate issue.Fix #1075