Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix or remove all broken links #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agilgur5
Copy link

@agilgur5 agilgur5 commented Jul 5, 2023

Summary

  • dc7c5b0 broke a decent amount of links
    • they were replaced with "Broken link" and "broken-reference"
    • due to either moving docs around/renaming, or because the docs no longer exist

Details

Review Notes

I'm not actually sure what to do about the removals:

  • Does the Metadata Store still exist? Not sure if it got integrated into all Data Systems? Could be added back under Data Systems?
  • Should the non-pip deps page be added back in a different place?

- dc7c5b0 broke a decent amount of links
  - they were replaced with "Broken link" and "broken-reference"
  - due to either moving docs around/renaming, or because the docs no longer exist

- fix Airflow reference in README
- fix Non-SQL reference in Porting a Workflow
- fix Conda reference in Operators
- fix Data Systems reference in Quickstart Guide
- fix Compute Systems reference in Creating a Workflow

- remove references to Aqueduct Metadata Store
  - the page on it was removed in dc7c5b0
  - links to it were removed in RunLLM@dc7c5b0#diff-649d189a8231566360ee2e0c865d203c86b590987d36383cebce29b06c3d7e2dL8 and RunLLM@dc7c5b0#diff-4f74b24c8cd7466c1c46dc972d8e284ed47091160afda95a432cc000f2eceb4aL99
- remove reference to non-pip connector dependency installation
  - the page was removed in dc7c5b0
  - the code seems to definitely still do this though, so maybe it should be added back under Data Systems?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant