Add FromBytes::from_bytes and AsBytes::as_bytes

[y86-dev]

• add FromBytes::from_bytes[_mut]: unsafe function that converts a (mutable) slice of bytes into a (mutable) reference to Self
• add AsBytes::as_bytes[_mut]: function that converts a (mutable) reference to Self into a (mutable) slice

Please also add examples to the documentation of the functions. These additions should be two patches.

---

This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag and a Link: tag to this issue. Please see https://rust-for-linux.com/contributing for details.

Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel. Please do not take it if you do not plan to make other contributions to the kernel.

[bjorn3]

as_bytes_mut would be unsound unless there is also a FromBytes bound. If the type implementing AsBytes has disallowed bit patterns, as_bytes_mut would allow creating a value which has one such disallowed bit pattern by using as_bytes_mut and then mutating through the &mut [u8] and finally accessing the original variable. Similar with from_bytes_mut unless there is a ToBytes bound.

[y86-dev]

Oh yeah that is true, good catch!

[Every2]

Hi, can I take this issue?

[y86-dev]

sure!

[Every2]

@y86-dev Do you mind explain the bjorn3 commentary? English isn't my main language and translating is being confuse to me. When he says "bound" is something like bound check? I mean, put a limit e.g &mut [u8] has to use only 255 as bound and something greater should be &mut [u16] . Thanks in advance!

[bjorn3]

An example of a bound would be:

trait Foo {
    fn bar(&self) where Self: Baz;
}

Here the where Self: Baz ensures that bar can only be called if Self (the type implementing the Foo trait) implements Baz too. You can add where Self: FromBytes to fn as_bytes_mut(...) -> ... and where Self: ToBytes to fn from_bytes_mut(...) -> ....

[Every2]

Hi, I again! Since we use ToBytes with where clause, maybe we can just return Self instead &Self and use type::from_ne_bytes and guarantee that is safe independent of endianness platform?

[Every2]

Hi, still working on it! I needed a break because my uni. Getting back to work now.