Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: add pr_debug. #452

Merged
merged 1 commit into from
Jul 22, 2021
Merged

rust: add pr_debug. #452

merged 1 commit into from
Jul 22, 2021

Conversation

wedsonaf
Copy link

This is used in the PL061 driver while we don't have dev_ variants.

Signed-off-by: Wedson Almeida Filho [email protected]

nbdd0121
nbdd0121 reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@nbdd0121 nbdd0121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unconditionally prints the message regardless whether DEBUG is enabled.

@nbdd0121
Copy link
Member

BTW, about dev_ variants, I have #300 which would allow a device to implement trait LogTarget and then dev_info(dev, ...) can be written as pr_info!(target: dev, ...).

@wedsonaf
rust: add pr_debug.
4010fe9 
This is used in the PL061 driver while we don't have `dev_` variants.

Signed-off-by: Wedson Almeida Filho <[email protected]>
@wedsonaf
Copy link
Author

This unconditionally prints the message regardless whether DEBUG is enabled.

Indeed. Fixed that and opened #453 to track CONFIG_DYNAMIC_DEBUG.

@ojeda ojeda mentioned this pull request Jul 22, 2021
Open
6 tasks
@ojeda ojeda merged commit 1ce1631 into Rust-for-Linux:rust Jul 22, 2021
@wedsonaf wedsonaf deleted the pr_debug branch July 22, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbdd0121 nbdd0121 nbdd0121 left review comments

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wedsonaf @nbdd0121 @alex @ojeda